Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33034: tools for building Sphinx docs from Pipelines #222

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Dec 21, 2021

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This PR is against a temporary branch, because merging this ticket (but not its review) is blocked by DM-33027. After that lands I'll rebase.

There are two largely mechanical commits here:

  • 80c65ab just moves existing code from ctrl_mpexec, with only trivial changes to import statements.

  • b014171 is mostly a bulk-rename followup to DM-31723 - I did that here because using ResourcePath in new code while leaving ButlerURI in nearby existing code was getting increasingly awkward.

The bulk of the changes are in 2d13499; everything else is just setup.

@timj
Copy link
Member

timj commented Sep 25, 2023

#347 has merged. I think that unblocks this ticket to allow it to be rebased on main rather than the temporary branch.

@TallJimbo
Copy link
Member Author

Yes, but there will definitely be conflicts as well as other work to get this branch working again. Might be best to just close the PRs and then delete the temporary base branches.

@timj timj changed the base branch from u/jbosch/DM-33034/review-base to main September 27, 2023 17:20
@timj
Copy link
Member

timj commented Sep 27, 2023

I dropped the commits from the base branch on the basis that you have already merged things (the expanded pipeline stuff was dropped?) and then the rebase was pretty straightforward once I also dropped all the ButlerURI renaming.

@TallJimbo
Copy link
Member Author

The expanded pipeline stuff morphed dramatically into PipelineGraph.

@timj
Copy link
Member

timj commented Sep 27, 2023

I've fixed up all the linting problems. @TallJimbo you may want to confirm it looks right for you before you delete your local branch.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: Patch coverage is 0% with 177 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (9eaaaf2) to head (2a3260b).

Files Patch % Lines
...ython/lsst/pipe/base/pipeline_graph/doc_builder.py 0.00% 177 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   81.23%   79.94%   -1.30%     
==========================================
  Files          96       97       +1     
  Lines       10922    11099     +177     
  Branches     2085     2127      +42     
==========================================
  Hits         8873     8873              
- Misses       1691     1868     +177     
  Partials      358      358              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants